Minor code cleanup #1079
Closed
Minor code cleanup #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made some readability changes and moved the resolved/reject handling code into functions outside of the Deferred constructor
|
I think I fixed it now, should be good to test |
Exanlv
reviewed
Mar 28, 2023
| $promise = coroutine([$handler, 'handle'], $data->d); | ||
| $promise->done([$deferred, 'resolve'], [$deferred, 'reject']); | ||
| $promise->done(&$onResolve, &$onReject); |
There was a problem hiding this comment.
Suggested change
| $promise->done(&$onResolve, &$onReject); | |
| $promise->done($onResolve, $onReject); |
There was a problem hiding this comment.
&$deferred was previously passed by reference, and these functions replace deferred
Exanlv
reviewed
Mar 28, 2023
| /** @var ExtendedPromiseInterface */ | ||
|
|
||
| if (! $this->emittedInit && ! in_array($data->t, $parse)) { | ||
| $this->unparsedPackets[] = function () use (&$handler, &$onResolve, &$onReject, &$data) { |
There was a problem hiding this comment.
Why are you passing these as reference?
There was a problem hiding this comment.
&$deferred was previously passed by reference, and these functions replace deferred
|
Closing this for now due to being outdated by almost two years. A lot has changed with Promises v3 and I'd feel more comfortable remaking this PR from scratch than trying to update it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some readability changes and moved the resolved/reject handling code into functions outside of the Deferred constructor, and used === instead of ==